(Backport 50725) mount: add fstab_{present,absent} states #54965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
changed the title
ghost
requested a review
from
aplanas
force-pushed
the
backport_50725
branch
from
5a91eb9
to
ae34159
Compare
dhiltonp
suggested changes
Dec 4, 2019
|
@dhiltonp they overlap, as the second one is build as a change for the first one. You can see it, for example, here: ae34159#diff-ba2bfb2cb504d0deb9fc5af6584c9032L994 |
|
Yeah. It is annoying having PRs that depend on each other. I certainly see why the 52962 port PR would include the 50725 commits, but there is value in also having an individual port PR for 50725. |
(cherry picked from commit 12ae2db)
aplanas
force-pushed
the
backport_50725
branch
from
ae34159
to
77881bb
Compare
aplanas
changed the title
dwoz
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add two new states in mount:
The code is adjusted to work on Linux, MacOS and AIX.
Tests written?
Yes
(backport #50725, already merged in develop)